-
Notifications
You must be signed in to change notification settings - Fork 63.1k
Update configuring-openid-connect-in-azure.md #38950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The version of the task doesn't exist so setting it to the newest version in the v2 family which works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the configuring-openid-connect-in-azure.md file to use the new Azure Login action version v2, ensuring that the correct and supported version is referenced.
- Updated the GitHub Actions step by replacing the commit-specific version with a simple v2 tag.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks for opening a PR! I'll get this triaged for review.
LGTM, could you resolve merge conflicts?
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment.
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment.
Yes this should stay opened
@wi5nia Would you be able to do a rebase or something else to resolve the conflicts? We changed the file structure of Actions and everything has gotten moved around. I might be able to figure out how to do it, but it would definitely be a git learning curve for me that would delay getting this merged further.
@wi5nia Would you be able to do a rebase or something else to resolve the conflicts? We changed the file structure of Actions and everything has gotten moved around. I might be able to figure out how to do it, but it would definitely be a git learning curve for me that would delay getting this merged further.
what? why? I just did a fork of GH official documentation and corrected the wrong information. I have no clue about the file structure or anything...
@Sharra-writes - I created a new PR if that makes any difference for you - #40200
@wi5nia That should work. It's nothing you did, we just changed a bunch of things that made this complicated. I know it's possible to fix, I'm even pretty sure it's something I could fix for you, it's just not something I've learned yet. I'll close this PR and get your new one approved.
The version of the task doesn't exist so setting it to the newest version in the v2 family which works.
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: