-
Notifications
You must be signed in to change notification settings - Fork 59
Open
Conversation
keithamus
requested review from
a team
and removed request for
a team and
manuelpuyol
October 12, 2022 13:49
primer-css
commented
Oct 12, 2022
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
- 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
- ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.
colebemis
commented
Oct 12, 2022
I don't feel qualified to review this since I don't have much web component experience. I'll defer to @koddsson for review.
jonrohan
jonrohan
approved these changes
Jan 19, 2023
@jonrohan
jonrohan
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice functionality 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
@slotdecorator for querying/manipulating/listening forslotelements.This also listens for
slotchangedevents and calls the setter which can be very useful for running side effects on a slot change.