Skip to content

Navigation Menu

Sign in
Sign up

V2 - #239

Open
keithamus wants to merge 28 commits into
main from
v2
Open

V2 #239
keithamus wants to merge 28 commits into
main from
v2

Conversation

@keithamus

@keithamus keithamus commented May 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

keithamus force-pushed the v2 branch 7 times, most recently from bd3c976 to d01d896 Compare May 20, 2022 16:41
keithamus force-pushed the v2 branch 6 times, most recently from 173d1b5 to 76bb1d4 Compare May 26, 2022 12:11
keithamus marked this pull request as ready for review June 6, 2022 17:36
keithamus requested a review from a team as a code owner June 6, 2022 17:36
keithamus requested a review from dgreif June 6, 2022 17:36

Copy link
Copy Markdown
Contributor Author

I've released a 2.0.0-alpha of this branch: https://github.com/github/catalyst/releases/tag/v2.0.0-alpha1. We'll test this out and kick the tires on it for a while before merging.

Copy link
Copy Markdown

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

keithamus requested review from a team and removed request for a team and dgreif October 12, 2022 13:49
keithamus and others added 22 commits October 12, 2022 15:13 
The current example throws error TS1207: Decorators cannot be applied to multiple get/set accessors of the same name.
I suggest updating documentation inline with advice from TS dev @mhegazy; see microsoft/TypeScript#2249 (comment) 
This allows classes to opt-in to old-style `data-` prefixed attr
serialised names.
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus and others added 3 commits October 12, 2022 15:14 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@attrable properties with a default value specified using a getter
method incorrectly have their setter method called with an empty
string.
This incorrect behaviour does not happen if:
- the property is in the html definition
- the property does not have a default value supplied by a getter method

adoublef commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown

I am unsure what the status is with v2 so I understand that it's still unstable and subject to changes. I am however finding in comparison to v1 that I am unable to use the target decorator to find the an element that is inside a shadowRoot

Hopefully I am not speaking out of turn with this. But I think the issue was due to the order in with the abilities are called in the in the controller decorator. Seems when I change the function body to register(targetable(actionable(attrable((Class)))));

In the targetable.ts file it set's the shadowRoot to the weakmap which I think was not being called (or overwritten) with the original controller decorator

 

Add failing test for default-valued properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koddsson koddsson Awaiting requested review from koddsson
1 more reviewer
@colebemis colebemis colebemis approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /