-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fixed: ordering of videos has been fixed at: /videos to show episodes in correct order #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... 1 and 3 on the left column, and 2 and 4 on the right column
Paulie-Aditya
commented
Sep 19, 2025
@To1ne Kindly let me know if the commit message is now appropriately defined, if not kindly guide me in the right direction for the same as well, would be more than happy to understand and contribute more meaningfully! Cheers!
To1ne
commented
Sep 26, 2025
@Paulie-Aditya Let me suggest something like:
fix ordering of videos
The videos are shown in a grid view. This is done by showing them in two
columns. But during implementation the columns where swapped.
Reorder the columns so the top left video is the first of the series.
Some notes from this:
- Start with a title, prefer to stay below 72 chars
- Followed by an empty line
- Then explain what the problem is (wrap lines at 80 chars)
- Then explain what you're changing
But I've noticed something else. On mobile (small screens) the order is still wrong. We should switch to CSS grid or flexbox to make sure the order is persisted across viewports.
Paulie-Aditya
commented
Sep 26, 2025
Okay, will do the changes as instructed, thanks for the guidance!
dscho
commented
Sep 30, 2025
I find it very nice to see progress here! Unfortunately, these changes are way over my head, so I cannot contribute to the review 😞
@To1ne
To1ne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Paulie-Aditya Awesome. I've added a few suggestions, but this is just what I wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We better also add box-sizing: border-box due to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do here:
&::before { content: counter(--video-index) "."; font-weight: normal; }
And on .video-thumbnails li do counter-increment: --video--index;, we would have counters on the videos.
Paulie-Aditya
commented
Oct 9, 2025
sorry been pre-occupied, will definitely implement these soon.
To1ne
commented
Oct 10, 2025
sorry been pre-occupied, will definitely implement these soon.
No worries, we all got stuff to do. 💜
Changes
Simply flipped over the conditions and that fixed it
in the left column: episodes 1 and 3
in the right column: episodes 2 and 4
Context
@To1ne brought this issue up once, that the video ordering on : https://git-scm.com/videos is wrong.
Specifically, episodes 2 and 4 are in the left column and the episodes 1 and 3 are in the right column.