-
-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
andrew
andrew
requested changes
Aug 12, 2026
@andrew
andrew
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both pkg:npm/@example/* and pkg:npm/%40example/* normalize to the same glob, but both entries remain in the sorted pattern list. If their durations differ, nondeterministic map iteration controls which entry matches first, so the same configuration can allow or block a package across restarts. Please deduplicate normalized globs with deterministic precedence, or reject conflicting entries, and add a collision test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add proxy-level cooldown package-pattern overrides as a policy wrapper, without changing the
cooldownlibrary.internal/cooldownpolicy, implementing the handler cooldown policy interface;@to%40in configured patterns, matching canonical PURL lookup behavior;cooldown.package_patterns.This is an initial policy layer for #127 and keeps namespace matching independent from the cooldown library, so it can later support other package-filtering policies.
Validation
go test ./...go vet ./...go build ./cmd/proxy