-
Notifications
You must be signed in to change notification settings - Fork 180
app: set focused attribue on fore/background events for ios and android - #162
Open
placid2000 wants to merge 4 commits into
Open
app: set focused attribue on fore/background events for ios and android #162placid2000 wants to merge 4 commits into
placid2000 wants to merge 4 commits into
Conversation
Signed-off-by: Cyril Mouttet <cyril.mouttet@gmail.com>
eliasnaur
commented
Feb 5, 2026
Contributor
In our discussion of this change, I wrote:
I now think the Config.Focused behaviour on Android is (subtly) wrong.
I'm thinking ofConfig.Focusedas "the window has (keyboard) focus",
that is that the window is the one the user is currently interacting
with. In that sense,Config.Focusedshould probably change to match
theonPause/onResumelifecycle state on Android. The Java
OnFocusChangedListenershould just be removed.
(With that change, it's possible thewindow.visibleandstarted
states can be tracked in anlifecycleenum).
Why not use onPause/onResume and what about the focus listener?
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
July 23, 2026 09:40
4d8d111 to
23e823d
Compare
placid2000
commented
Aug 19, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This path set focused flag in ConfigEvent when app goes back or foreground on ios and android