adding check if char == '-', if so not using as modifier for keypress - #105

Open

sheik wants to merge 2 commits into

gioui:main from

sheik:fix_hyphen_key

Open

adding check if char == '-', if so not using as modifier for keypress #105
sheik wants to merge 2 commits into
gioui:main from
sheik:fix_hyphen_key

Conversation

@sheik

@sheik sheik commented Dec 8, 2022

Copy link

Copy Markdown

No description provided.

@whereswaldon

whereswaldon commented Dec 8, 2022

Copy link

Copy Markdown

Member

Thanks for the PR! Please sign off your commit message.

@sheik


 adding check if char == '-', if so not using as modifier

bb032a9

Fixes: https://todo.sr.ht/~eliasnaur/gio/432
Signed-off-by: Jeff Aigner <enumeration@gmail.com>

@sheik

sheik force-pushed the fix_hyphen_key branch from 44d331b to bb032a9 Compare

December 8, 2022 18:51

@sheik

sheik commented Dec 8, 2022

Copy link

Copy Markdown

Author

Done. Please let me know if I've done something incorrectly 🤪

whereswaldon

whereswaldon requested changes

Dec 8, 2022

View reviewed changes

@whereswaldon whereswaldon left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there're some unhanded edge cases, but thanks for tackling this!

io/key/key.go Outdated

Comment on lines +241 to +245

if chord == "-" {

modSet, keySet = "", chord

} else {

modSet, keySet = chord[:sep], chord[sep+1:]

}

@whereswaldon whereswaldon Dec 8, 2022

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I am misreading, but this seems like it would only work to bind to literal presses of -. It doesn't handle modifier keys in combination with - such as Short-- or Ctrl--. Here's a playground demonstrating some of the failure cases. I think whatever we do needs to handle all of the ones I put in the playground, probably by detecting when the final character is - and doing special processing.