-
-
Notifications
You must be signed in to change notification settings - Fork 190
ref(types): Store SampleRand as integer ticks - #1313
Draft
szokeasaurusrex wants to merge 1 commit into
Draft
Conversation
`SampleRand` was added a while ago ([#867](#867), [#868](#868)) but has barely been used in the SDK since. Upcoming work will use it as the sampling seed, per the propagated random value spec. Reinterpret the value as an integer number of ticks (one tick = `0.000001`), aligning the representation with the fixed six-decimal string propagated on the wire: `Display` always emits exactly six digits, parsing avoids floats, and 1.0 becomes unrepresentable. References [#735](#735) References [RUST-1](https://linear.app/getsentry/issue/RUST-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
SampleRandwas added a while ago (#867, #868) but has barely been used in the SDK since. Upcoming work will use it as the sampling seed, per the propagated random value spec.Reinterpret the value as an integer number of ticks (one tick =
0.000001), aligning the representation with the fixed six-decimal string propagated on the wire:Displayalways emits exactly six digits, parsing avoids floats, and 1.0 becomes unrepresentable.References #735
References RUST-1