-
Notifications
You must be signed in to change notification settings - Fork 583
Comments
fix(openai): Avoid consuming iterables passed to the Completions API#5489
Open
alexander-alderman-webb wants to merge 4 commits intomaster from
Open
fix(openai): Avoid consuming iterables passed to the Completions API #5489alexander-alderman-webb wants to merge 4 commits intomaster from
alexander-alderman-webb wants to merge 4 commits intomaster from
Conversation
@alexander-alderman-webb
alexander-alderman-webb
requested a review
from a team
as a code owner
February 20, 2026 10:34
Contributor
Semver Impact of This PR
🟢 Patch (bug fixes)
📋 Changelog Preview
This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).
Bug Fixes 🐛
- (openai) Avoid consuming iterables passed to the Completions API by alexander-alderman-webb in
#5489
Internal Changes 🔧
- (agents) Add sentry skills to be used by warden in CI reviews by ericapisani in
#5485 - (ai) Add configuration for dotagents by ericapisani in
#5480 - (openai-agents) Expect new tool fields by alexander-alderman-webb in
#5471 - (repo) Add .serena to .gitignore by ericapisani in
#5464 - 🤖 Update test matrix with new releases (02/19) by github-actions in
#5483 - 🤖 Update test matrix with new releases (02/18) by github-actions in
#5475
🤖 This preview updates automatically when you update the PR.
Contributor
Codecov Results 📊✅ 1860 passed | ⏭️ 154 skipped | Total: 2014 | Pass Rate: 92.35% | Execution Time: 3m 31s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 11751 uncovered lines. Files with missing lines (173)
Generated by Codecov Action |
@alexander-alderman-webb
alexander-alderman-webb
marked this pull request as draft
February 20, 2026 13:22
@alexander-alderman-webb
alexander-alderman-webb
marked this pull request as draft
February 20, 2026 13:22
@alexander-alderman-webb
alexander-alderman-webb
marked this pull request as ready for review
February 20, 2026 13:46
ericapisani
ericapisani
approved these changes
Feb 20, 2026
Member
@ericapisani
ericapisani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing I noticed but otherwise LGTM
# dict special case following https://github.com/openai/openai-python/blob/3e0c05b84a2056870abf3bd6a5e7849020209cc3/src/openai/_utils/_transform.py#L194-L197
if not isinstance(messages, Iterable) or isinstance(messages, dict):
set_data_normalized(span, SPANDATA.GEN_AI_OPERATION_NAME, "chat")
_commmon_set_input_data(span, kwargs)
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Typo on the function name (can be cleaned up in a follow up change)
Suggested change
_commmon_set_input_data(span, kwargs)
_common_set_input_data(span, kwargs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Avoid consuming single-use iterators passed to the Completions API. The Completions API is typed more liberally than the Responses API and accepts single-use iterators.
Consumable iterables nested inside the
messagesobject are out of scope for this PR.All iterables that are not dictionaries or strings are transformed to lists in the internals of
openaibefore they are passed to the API call:https://github.com/openai/openai-python/blob/3e0c05b84a2056870abf3bd6a5e7849020209cc3/src/openai/_utils/_transform.py#L154
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)