-
Notifications
You must be signed in to change notification settings - Fork 584
Comments
fix(google-genai): Remove agent spans for simple requests#5443
Open
alexander-alderman-webb wants to merge 3 commits intomaster from
Open
fix(google-genai): Remove agent spans for simple requests #5443alexander-alderman-webb wants to merge 3 commits intomaster from
alexander-alderman-webb wants to merge 3 commits intomaster from
Conversation
Contributor
Semver Impact of This PR
🟢 Patch (bug fixes)
📋 Changelog Preview
This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).
Bug Fixes 🐛
- (anthropic) Fix token accounting by shellmayr in
#5490
- (google-genai) Remove agent spans for simple requests by alexander-alderman-webb in
#5443
Documentation 📚
- New integration guide by alexander-alderman-webb in
#5476
Internal Changes 🔧
- (agents) Add sentry skills to be used by warden in CI reviews by ericapisani in
#5485 - (ai) Add configuration for dotagents by ericapisani in
#5480 - (openai-agents) Expect new tool fields by alexander-alderman-webb in
#5471 - (repo) Add .serena to .gitignore by ericapisani in
#5464 - 🤖 Update test matrix with new releases (02/19) by github-actions in
#5483 - 🤖 Update test matrix with new releases (02/18) by github-actions in
#5475
🤖 This preview updates automatically when you update the PR.
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.25s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13670 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
@alexander-alderman-webb
alexander-alderman-webb
marked this pull request as ready for review
February 20, 2026 15:23
@alexander-alderman-webb
alexander-alderman-webb
requested a review
from a team
as a code owner
February 20, 2026 15:23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
ericapisani
ericapisani
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Remove all
gen_ai.invoke_agentspans from thegoogle-genaiintegration.An agent span must capture multiple model calls, or some auxiliary work that goes beyond transforming the model input and output. The agent spans in
google-genaionly wrapped simple model requests, and are therefore semantically misplaced.All attributes are duplicated between
gen_ai.invoke_agentandgen_ai.chatspans. Agents sit at a higher level of abstraction than model requests, and Google has thegoogle-adkfor agentic flows (https://github.com/google/adk-python).Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)