-
Notifications
You must be signed in to change notification settings - Fork 583
Comments
Open
Conversation
Comment on lines
+928
to
929
pre-commit run --all-files
mypy sentry_sdk
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is okay. Explicitly saying that files shouldn't be changed doesn't yield a benefit on CI.
@ulgens
ulgens
changed the title
(削除) fix: DRY ruff calls (削除ここまで)
(追記) ci: DRY ruff calls (追記ここまで)
Dec 26, 2025
@ulgens
ulgens
force-pushed
the
simplify-ruff-call
branch
from
January 7, 2026 12:16
6037f2a to
ade2e99
Compare
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (2ce4379) to head (ade2e99).
Additional details and impacted files
@@ Coverage Diff @@ ## master #5267 +/- ## ========================================== - Coverage 84.25% 84.17% -0.08% ========================================== Files 181 182 +1 Lines 18463 18656 +193 Branches 3288 3316 +28 ========================================== + Hits 15556 15704 +148 - Misses 1894 1938 +44 - Partials 1013 1014 +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was checking the lint setup and realized running pre-commit locally on latest main doesn't produce a clean result. I checked why this wasn't the case on CI and found out that pre-commit ruff and CI ruff use slightly different configuration. I tried to centralize that config, and found out there is a bug with ruff-pre-commit but still DRY'ed the ruff calls.
Considering the removal of the "include" setting causes only a single change in a single file, I think that settings can be removed compeletely but I didn't want to change configuration without asking about it first.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)