-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nextjs): fix createRouteManifest with basePath #17838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): fix createRouteManifest with basePath #17838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Route Manifest Cache and Base Path Handling
The createRouteManifest cache doesn't invalidate when the basePath option changes, leading to stale manifests with incorrect route prefixes. Also, passing options?.basePath directly to scanAppDirectory can prefix routes with 'undefined/' when basePath is not provided.
Looks good already, would you mind also reflecting this in one of the e2e-tests (dev-packages/e2e-tests/test-applications)?
Looks good already, would you mind also reflecting this in one of the e2e-tests (
dev-packages/e2e-tests/test-applications)?
If I apply a basePath to the existing E2E test application, it seems that all transaction assertions and URL paths in the test code would need to include the basePath prefix.
Is this the recommended approach?
Could you provide some guidance on whether it would be better to add tests directly to the existing app, or to create a separate app with basePath enabled for testing purposes?
We can move this into a new next-15-basepath test. Feel free to ping me if I should take this over!
Uh oh!
There was an error while loading. Please reload this page.
fix #17837
add basePath prefix to createRouteManifest
closes #17837