Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix/17514 #17786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xbad0c0d3 wants to merge 6 commits into getsentry:develop
base: develop
Choose a base branch
Loading
from 0xbad0c0d3:fix/17514
Open

Fix/17514 #17786

0xbad0c0d3 wants to merge 6 commits into getsentry:develop from 0xbad0c0d3:fix/17514

Conversation

Copy link
Contributor

@0xbad0c0d3 0xbad0c0d3 commented Sep 25, 2025
edited by cursor bot
Loading

I was running tests locally and noticed that they are stays running if something wents wrong that's why I've added: 04d2fbf

fixes #17514

Is there a way to run e2e tests pipeline without merging to develop?


Note

Introduce copyExecutionContext with tests; make Cloudflare integration test runner accept AbortSignal and update tests; ignore JUnit reports.

  • Cloudflare SDK:
    • Utility: Add packages/cloudflare/src/utils/copyExecutionContext.ts to clone ExecutionContext/DurableObjectState with overridable, bound methods.
    • Tests: Add packages/cloudflare/test/copy-execution-context.test.ts covering method overriding, immutability safety, and symbol property preservation.
  • Integration Tests (Cloudflare):
    • Runner: dev-packages/cloudflare-integration-tests/runner.ts start now accepts optional AbortSignal and forwards it to spawn.
    • Suites: Update tests (basic, tracing/anthropic-ai, tracing/durableobject, tracing/openai) to pass { signal } from Vitest and call .start(signal).
  • Repo:
    • .gitignore: Ignore packages/**/*.junit.xml JUnit reports.

Written by Cursor Bugbot for commit cb97187. This will update automatically on new commits. Configure here.

seer-by-sentry[bot] reacted with hooray emoji
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

mydea commented Sep 26, 2025

You should be able to run E2E tests locally:

cd dev-packages/e2e-tests
yarn test:run test-app-name

This requires docker & pnpm to be setup!

Copy link
Member

@0xbad0c0d3 is this ready for review?

Copy link
Contributor Author

No, not yet, sorry for the delay.

Copy link
Member

No worries, just wasn't sure :) When you're ready, please request me as a reviewer.

Copy link
Contributor Author

You should be able to run E2E tests locally:

cd dev-packages/e2e-tests
yarn test:run test-app-name

This requires docker & pnpm to be setup!

and also volta

cod1k added 6 commits September 30, 2025 15:55
Updated test definitions across multiple suites to accept and pass abort signals (`signal`) for enhanced request handling. Adjusted the `start` method in the test runner to support optional abort signals.
Reworked `copyExecutionContext` to use a dynamic property descriptor approach, enabling method overrides without altering the original object. Expanded test cases to cover additional methods and verify override behavior.
Enhanced the descriptor logic to better handle non-function properties and prevent invalid method overrides. Fixed potential issues with binding non-function properties to the context.
Updated the `OverridesStore` type to strictly associate keys with context-specific methods, improving type safety. Renamed and enhanced the descriptor creation function to better handle method overriding and added checks for function-only properties.
Added `packages/**/*.junit.xml` to `.gitignore` to prevent JUnit report files from being tracked in the repository, keeping the working directory clean and avoiding unnecessary versioning of test artifacts.
Copy link
Contributor Author

@andreiborza so, it is ready

andreiborza reacted with thumbs up emoji

Copy link
Member

Thanks! Will take a look in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@andreiborza andreiborza Awaiting requested review from andreiborza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/cloudflare crashes DurableObjects due to unsafe & unnecessary proxying of waitUntil()

AltStyle によって変換されたページ (->オリジナル) /