-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(react): Remove handleExistingNavigation
#17534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
1ba555f
to
0a34f8b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: Can you explain the change of this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the first block of this condition was updating the span name depending on the context of a lazy-route. That was the reason for the faulty transaction name updates (as the previous navigation transaction's name / route was leaking into the current one).
Turns out it's unnecessary (and also regressed the bug we were trying to fix).
Removing this whole handleExistingNavigationSpan
logic (with its lazy-route context checks) fixed the issue, without breaking anything else. We still need to check if we are already inside a navigation span, for the instrumentation cross-usage to prevent nesting / duplication.
Uh oh!
There was an error while loading. Please reload this page.
Removes recently introduced special-casing lazy-route -> lazy-route transaction name updates.
This completes the fix in #17438.
E2E tests are updated to replicate a similar case in the reproduction here: #17417
Also manually tested on the reproduction.