Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(browser): Ensure parentSpanId stays consistent during trace in TwP mode #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lms24 wants to merge 4 commits into develop
base: develop
Choose a base branch
Loading
from lms/ref-browser-propagationSpanId

Conversation

Copy link
Member

@Lms24 Lms24 commented Sep 3, 2025 •
edited
Loading

draft for now to see what we break with this again 😬

builds on top of #17509

seer-by-sentry[bot] reacted with hooray emoji
@Lms24 Lms24 marked this pull request as draft September 3, 2025 14:58
@Lms24 Lms24 changed the title (ε‰Šι™€) fix(browser): Ensure parentSpanId stays consistent in TwP mode (ε‰Šι™€γ“γ“γΎγ§) (追記) fix(browser): Ensure parentSpanId stays consistent during trace in TwP mode (θΏ½θ¨˜γ“γ“γΎγ§) Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

size-limit report πŸ“¦

Path Size % Change Change
@sentry/browser 24.16 kB - -
@sentry/browser - with treeshaking flags 22.73 kB - -
@sentry/browser (incl. Tracing) 40.15 kB +0.06% +23 B πŸ”Ί
@sentry/browser (incl. Tracing, Replay) 78.49 kB +0.04% +27 B πŸ”Ί
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.27 kB +0.04% +26 B πŸ”Ί
@sentry/browser (incl. Tracing, Replay with Canvas) 83.17 kB +0.03% +23 B πŸ”Ί
@sentry/browser (incl. Tracing, Replay, Feedback) 95.39 kB +0.03% +27 B πŸ”Ί
@sentry/browser (incl. Feedback) 40.89 kB - -
@sentry/browser (incl. sendFeedback) 28.81 kB - -
@sentry/browser (incl. FeedbackAsync) 33.75 kB - -
@sentry/react 25.88 kB - -
@sentry/react (incl. Tracing) 42.12 kB +0.06% +23 B πŸ”Ί
@sentry/vue 28.64 kB - -
@sentry/vue (incl. Tracing) 41.95 kB +0.06% +21 B πŸ”Ί
@sentry/svelte 24.18 kB - -
CDN Bundle 25.74 kB +0.02% +3 B πŸ”Ί
CDN Bundle (incl. Tracing) 40.03 kB +0.11% +42 B πŸ”Ί
CDN Bundle (incl. Tracing, Replay) 76.31 kB +0.06% +42 B πŸ”Ί
CDN Bundle (incl. Tracing, Replay, Feedback) 81.78 kB +0.06% +47 B πŸ”Ί
CDN Bundle - uncompressed 75.29 kB +0.18% +129 B πŸ”Ί
CDN Bundle (incl. Tracing) - uncompressed 118.52 kB +0.22% +256 B πŸ”Ί
CDN Bundle (incl. Tracing, Replay) - uncompressed 233.61 kB +0.11% +256 B πŸ”Ί
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.37 kB +0.11% +256 B πŸ”Ί
@sentry/nextjs (client) 44.14 kB +0.05% +19 B πŸ”Ί
@sentry/sveltekit (client) 40.59 kB +0.05% +20 B πŸ”Ί
@sentry/node-core 49.67 kB -0.04% -16 B πŸ”½
@sentry/node 150.66 kB -0.01% -8 B πŸ”½
@sentry/node - without tracing 92.25 kB -0.02% -13 B πŸ”½
@sentry/aws-serverless 105.55 kB -0.02% -12 B πŸ”½

View base workflow run

Base automatically changed from lms/feat-browser-propagateTraceparent to develop September 4, 2025 11:22
@Lms24 Lms24 force-pushed the lms/ref-browser-propagationSpanId branch from afe61cf to e84c9be Compare September 4, 2025 12:12
Copy link
Contributor

github-actions bot commented Sep 4, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,825 - 9,048 -2%
GET With Sentry 1,311 15% 1,254 +5%
GET With Sentry (error only) 5,984 68% 5,872 +2%
POST Baseline 1,203 - 1,179 +2%
POST With Sentry 496 41% 476 +4%
POST With Sentry (error only) 1,066 89% 1,024 +4%
MYSQL Baseline 3,274 - 3,266 +0%
MYSQL With Sentry 431 13% 387 +11%
MYSQL With Sentry (error only) 2,652 81% 2,684 -1%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /