Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(nextjs): Add route handler tests for turbopack #17515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chargome wants to merge 4 commits into develop
base: develop
Choose a base branch
Loading
from cg-add-route-handler-tests

Conversation

Copy link
Member

@chargome chargome commented Sep 3, 2025

Adds tests for tracing and exception handling in turbopack route handlers.

Note: this will fail until vercel/next.js#82612 is resolved

seer-by-sentry[bot] reacted with hooray emoji
@chargome chargome self-assigned this Sep 3, 2025
expect(routehandlerTransaction.contexts?.trace?.op).toBe('http.server');
});

test('Should record exceptions and transactions for faulty route handlers', async ({ request }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make this test.fail so it will expect to fail and we will be "notified" when this is fixed! (+ add a comment for this)

chargome reacted with eyes emoji
Copy link
Member Author

@chargome chargome Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.fail seems to not work with test timeouts – I added a workaround so the test fails once the issue is resolved upstream

Copy link
Member Author

@chargome chargome Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this is already fixed in canary. leaving as is

@chargome chargome marked this pull request as ready for review September 3, 2025 15:25
@chargome chargome enabled auto-merge (squash) September 3, 2025 15:26
Copy link
Contributor

github-actions bot commented Sep 3, 2025
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,930 - 8,687 +3%
GET With Sentry 1,335 15% 1,275 +5%
GET With Sentry (error only) 5,917 66% 5,998 -1%
POST Baseline 1,197 - 1,142 +5%
POST With Sentry 488 41% 496 -2%
POST With Sentry (error only) 1,074 90% 984 +9%
MYSQL Baseline 3,333 - 3,247 +3%
MYSQL With Sentry 425 13% 435 -2%
MYSQL With Sentry (error only) 2,718 82% 2,648 +3%

View base workflow run

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mydea mydea Awaiting requested review from mydea

At least 1 approving review is required to merge this pull request.

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /