-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(flags): Adds Growthbook integration #17440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Adds Growthbook integration #17440
Conversation
@Lms24 Would you approve the workflows to run again?
Tysm for the integration @madhuchavva !! Will take a look soon
record results of type (booleans, strings, numbers, null, objects/arrays)
For now Sentry is limiting all FF integrations to boolean only. We plan to rollout non-bool support later - would you mind removing those types from this PR?
relates to getsentry/sentry#82157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we can support this in node too, by moving the integration to core - what are the differences in the GrowthBookClass template and evaluation methods? In https://docs.growthbook.io/lib/node it looks like they take a userContext arg - could we workaround this by handling additional args in the patcher?
Uh oh!
There was an error while loading. Please reload this page.
Adds GrowthBook's integration for tracking feature evaluations.
This PR includes changes to wrap
isOn, getFeatureValue andevalFeaturemethods, record results of type (booleans, strings, numbers, null, objects/arrays) and attach them to active span or current scope buffer for errors.