-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Allow to configure disableIntegrations
to opt-out of default integrations
#15300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new top-level config allows to opt-out of any added integration, ensuring it is not actually added. This is mainly designed to opt-out of default integrations, but will also apply to any manually added integration. There are type hints that should help with usage there, but any key is allowed to keep this flexible. Type hints are manually configured (could not find a way to infer this from integrations, as the names are not statically exposed there...) for now. Usage: ```js Sentry.init({ disableIntegrations: { BrowserSession: true, InboundFilters: false } }); ``` Will disable the browserSessionIntegration but not the inboundFilters one.
@mydea
mydea
force-pushed
the
fn/default-integrations-opt-out
branch
from
February 5, 2025 10:19
e99bbf7
to
ce18641
Compare
size-limit report 📦
|
Once #15307 is merged, we can refactor this to instead allow configuring defaultIntergations: { InboundFilters: false }
, which is a better API probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new top-level config allows to opt-out of any added integration, ensuring it is not actually added.
This is mainly designed to opt-out of default integrations, but will also apply to any manually added integration.
There are type hints that should help with usage there, but any key is allowed to keep this flexible. Type hints are manually configured (could not find a way to infer this from integrations, as the names are not statically exposed there...) for now.
image
Usage:
Will disable the browserSessionIntegration but not the inboundFilters one.
Syntax
The linked issue proposed to allow to pass
{ IntegrationName: false }
todefaultIntegrations
. While this is a nice API from a users POV, it is trickier than I imagined - the problem is the logic we have around defaultIntergations. E.g. the browser SDK will basically do this:Which makes it much trickier to handle these things and would require bigger changes in various places 😬 So this PR tries a different approach, by having a new config property for this 🤔 If there are other ideas/thoughts around this, happy to hear them!
Closes #14950