This repository was archived by the owner on Oct 23, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 653
Do not record errors for terminals #924
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dcramer
commented
Dec 5, 2016
offline conversation around this was how noisy things like custom scripts are when you're fucking around from a terminal
+1
Contributor
Author
mitsuhiko
commented
Dec 5, 2016
@dcramer added test
Contributor
mattrobenolt
commented
Dec 14, 2016
Why not just entirely skip installing the hook if it's not a tty? Is it possible that stdin being a tty could change while the process is running?
Contributor
Author
@mattrobenolt i don't know if it can change on the same stream but there are a few cases where this can be an issue:
- you fork off a child and close the input stream
- someone patches sys.stdin at runtime
We've been going nuts with typos on an interactive console causing emails from Sentry, and the delay that sending the message causes when we do hit errors from the console before it shows us the error interactively. We would really appreciate this feature!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not record errors by default if a tty is detected. If you
want to record anyways do not register the default hook and manually
install it with the flag flipped.