This repository was archived by the owner on Oct 23, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 653
Default usage of raven.Client does not import twisted or requests #1260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
skrap
commented
Jun 12, 2018
Build failures seem unrelated to these changes:
pkg_resources.VersionConflict: (pytest 3.2.5 (/home/travis/build/getsentry/raven-python/.tox/py35-django-200-fix/lib/python3.5/site-packages), Requirement.parse('pytest>=3.6'))
Contributor
ashwoods
commented
Jun 12, 2018
Yup, almost have a fix ready
Contributor
ashwoods
commented
Jul 11, 2018
@skrap fixed, then broke again,then fixed again. Mind rebasing from master?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This patch addresses #1258 by taking steps to lazily load the requests and twisted modules.
Summary of changes:
hook_librariesfunction if the module requested hasn't been loaded yet.twistedandrequestsin their respective transport subclasses. Lazy load what's needed.Caveats:
Results:
from raven import Clienttakes 2.3 MB instead of 17 MB RSS.