This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Add the Client.install_asyncio_hook function. #1134

Open

Kentzo wants to merge 1 commit into getsentry:master

from GreatFruitOmsk:asyncio

Open

Add the Client.install_asyncio_hook function. #1134

Kentzo wants to merge 1 commit into getsentry:master from GreatFruitOmsk:asyncio

Conversation

@Kentzo

Copy link

@Kentzo Kentzo commented Nov 12, 2017 •

edited

Loading

asyncio needs special handling as its unhandled exceptions are consumed by logging and ignoring them.

@asvetlov Please take a look at the implementation and let me know if handling can be improved. I used implementation of BaseEventLoop.default_exception_handler as a reference but didn't check all available context's keywords in all released versions of Python.

@Kentzo Kentzo force-pushed the asyncio branch 5 times, most recently from 613df38 to 7439554 Compare

November 12, 2017 06:09

@ashwoods ashwoods self-requested a review

November 12, 2017 15:28

@ashwoods ashwoods self-assigned this

Nov 12, 2017

@Kentzo Kentzo force-pushed the asyncio branch from 7439554 to 1f3619a Compare

November 12, 2017 19:28

@Kentzo


 Add the Client.install_asyncio_hook function.

ac20b33

@Kentzo Kentzo force-pushed the asyncio branch from 1f3619a to ac20b33 Compare

November 13, 2017 03:13

@Kentzo

Copy link

Author

Kentzo commented Nov 13, 2017

I'm not sure how to cause asyncio to call exception handler without 'exception' but with handle of future with the _source_traceback attribute set.

@Kentzo

Copy link

Author

Kentzo commented Nov 13, 2017

@ashwoods I used the 'exception' level instead of 'fatal' as handled errors don't explicitly cause interpreter to exit by default. Was it a good idea?