Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a Helmchart for GeoHealthCheck#482

Open
stranljip wants to merge 16 commits intogeopython:master from
DisyInformationssysteme:helmchart
Open

Add a Helmchart for GeoHealthCheck #482
stranljip wants to merge 16 commits intogeopython:master from
DisyInformationssysteme:helmchart

Conversation

@stranljip
Copy link

@stranljip stranljip commented Feb 25, 2025

This PR adds a Helm chart for GeoHealth check which allows an easy deployment on Kubernetes.

Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
@stranljip stranljip changed the title (削除) Draft: Add a Helmchart for GeoHealthCheck (削除ここまで) (追記) Add a Helmchart for GeoHealthCheck (追記ここまで) Feb 26, 2025
Copy link
Author

Closes #483

Copy link
Author

This PR does not yet provide a publication mechanism for the Helmchart - this is something which should be done after incorporating the Helmchart.

Copy link
Author

Hi - are there any contributors in this project who can have a look at my PR or is this project unmaintained and I should continue the work solely on my fork?

Copy link
Member

justb4 commented Apr 29, 2025

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.

I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future.
My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s?
Ok @tomkralidis ?

Copy link
Member

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.

I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions, thanks for this contribution!

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

Copy link
Author

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

The Helm chart does only apply to k8s. docker/helm and docker/kubernetes do not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:

  • docker --> install/docker-compose
  • charts --> install/kubernetes/charts or charts/geohealthcheck --> install/kubernetes/helmchart

Copy link
Author

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your docs dir?

Copy link
Member

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

The Helm chart does only apply to k8s. docker/helm and docker/kubernetes do not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:

* `docker` --> `install/docker-compose`
* `charts` --> `install/kubernetes/charts` or `charts/geohealthcheck` --> `install/kubernetes/helmchart`

fine to create /charts as you with (while keeping /docker the same).

stranljip reacted with thumbs up emoji

Copy link
Member

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your docs dir?

Yes, add a Makefile so anyone wanting to run Helm has some help. For docs, thinking more, move the content of charts/docs/installhelm.rst (of this PR) into docs/install.rst add a section to page docs/install.rst.

stranljip reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomkralidis tomkralidis tomkralidis requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /