-
-
Notifications
You must be signed in to change notification settings - Fork 74
Add a Helmchart for GeoHealthCheck#482
Add a Helmchart for GeoHealthCheck #482stranljip wants to merge 16 commits intogeopython:master from
Conversation
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
Signed-off-by: heidmann <carsten.heidmann@disy.net>
abeb6a1 to
b899215
Compare
stranljip
commented
Feb 26, 2025
Closes #483
stranljip
commented
Feb 26, 2025
This PR does not yet provide a publication mechanism for the Helmchart - this is something which should be done after incorporating the Helmchart.
stranljip
commented
Mar 24, 2025
Hi - are there any contributors in this project who can have a look at my PR or is this project unmaintained and I should continue the work solely on my fork?
justb4
commented
Apr 29, 2025
Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future.
My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s?
Ok @tomkralidis ?
tomkralidis
commented
May 9, 2025
Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the
chartsdirectory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dirchartscould be confusing, as within GHC we also draw status charts. Is it an idea to name the dirk8s? Or does Helm apply and the files underchartsapply to more than K8s? Ok @tomkralidis ?
I'd probably create docker/helm and docker/kubernetes accordingly.
@tomkralidis
tomkralidis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions, thanks for this contribution!
I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.
stranljip
commented
May 9, 2025
Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under thechartsdirectory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dirchartscould be confusing, as within GHC we also draw status charts. Is it an idea to name the dirk8s? Or does Helm apply and the files underchartsapply to more than K8s? Ok @tomkralidis ?I'd probably create
docker/helmanddocker/kubernetesaccordingly.
The Helm chart does only apply to k8s. docker/helm and docker/kubernetes do not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:
docker-->install/docker-composecharts-->install/kubernetes/chartsorcharts/geohealthcheck-->install/kubernetes/helmchart
stranljip
commented
May 9, 2025
I would also suggest adding a new page in the docs on this functionality, as well as a
Makefileas a convenience.
I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your docs dir?
tomkralidis
commented
Jun 2, 2025
Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under thechartsdirectory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dirchartscould be confusing, as within GHC we also draw status charts. Is it an idea to name the dirk8s? Or does Helm apply and the files underchartsapply to more than K8s? Ok @tomkralidis ?I'd probably create
docker/helmanddocker/kubernetesaccordingly.The Helm chart does only apply to k8s.
docker/helmanddocker/kubernetesdo not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:* `docker` --> `install/docker-compose` * `charts` --> `install/kubernetes/charts` or `charts/geohealthcheck` --> `install/kubernetes/helmchart`
fine to create /charts as you with (while keeping /docker the same).
tomkralidis
commented
Jun 2, 2025
I would also suggest adding a new page in the docs on this functionality, as well as a
Makefileas a convenience.I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your
docsdir?
Yes, add a Makefile so anyone wanting to run Helm has some help. For docs, thinking more, move the content of charts/docs/installhelm.rst (of this PR) into docs/install.rst add a section to page docs/install.rst.
This PR adds a Helm chart for GeoHealth check which allows an easy deployment on Kubernetes.