-
Notifications
You must be signed in to change notification settings - Fork 172
OCI Support for manifests command and server tags page#202
Open
elerch wants to merge 18 commits intogenuinetools:master from
Open
OCI Support for manifests command and server tags page #202elerch wants to merge 18 commits intogenuinetools:master from
elerch wants to merge 18 commits intogenuinetools:master from
Conversation
Note that this loosens the checks for the returned manifest and simply returns a bag of bytes from registry
athos-ribeiro
commented
Mar 7, 2020
Thank you, I am quite interested in this feature as well!
What if the endpoint returns an OCI index instead of an image manifest?
Author
elerch
commented
Mar 7, 2020
The endpoint shouldn't return an index. The accept header I send to the server is only asking for v2 and OCI manifest types.
That said, if it were to return an index for some reason, there's no longer validation of the return data, so reg manifest would return the resultant data, and the tags page rendered from the server command would fail to operate.
athos-ribeiro
commented
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows OCI images to be displayed through the manifest command. It also fixes my scenario on #173 which was caused by the create date being determined via a docker v1 manifest. That is now determined by getting a v2/OCI manifest, then acquiring the resultant config blob from the registry that should have the create date (we luck out that both docker v2 and OCI config json have createdDate in the base object).