-
Notifications
You must be signed in to change notification settings - Fork 172
Proposal: Add pagination to tags page #89#116
Open
knopka wants to merge 3 commits intogenuinetools:master from
Open
Proposal: Add pagination to tags page #89 #116knopka wants to merge 3 commits intogenuinetools:master from
knopka wants to merge 3 commits intogenuinetools:master from
Conversation
jstoja
jstoja
reviewed
Oct 2, 2018
Contributor
@jstoja
jstoja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not manage to make it work because of static templates that are not fetch, any idea why @knopka ?
"github.com/genuinetools/reg/registry"
"github.com/gorilla/mux"
"github.com/sirupsen/logrus"
"github.com/knopka/go-pagination-bootstrap"
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this import. I'm not sure having an external import that renders HTML that is from outside this repository is the way to go, but I might be wrong.
}
.pagination a {
font-size: small;
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's one indent too much ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.