-
Notifications
You must be signed in to change notification settings - Fork 139
feat: Increase search result limits and display total matches and fil...#996
feat: Increase search result limits and display total matches and fil... #996prath47 wants to merge 2 commits intogeneralaction:main from
Conversation
...e count in search results.
@prath47 is attempting to deploy a commit to the General Action Team on Vercel.
A member of the Team first needs to authorize it.
Greptile SummaryIncreases search result limits from 100 to 10,000 across all search implementations (local, remote, and frontend) to provide comprehensive search results. Adds a user-friendly summary line showing total line matches and file count. Changes:
Considerations:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/main/services/fs/LocalFileSystem.ts | Increased default maxResults from 100 to 10000 |
| src/main/services/fs/RemoteFileSystem.ts | Increased default maxResults from 100 to 10000 for remote search |
| src/main/services/fsIpc.ts | Increased DEFAULT_MAX_SEARCH_RESULTS to 10000 and MAX_SEARCH_FILES to 20000 |
| src/renderer/components/FileExplorer/ContentSearchResults.tsx | Added search results summary showing total line matches and file count |
| src/renderer/hooks/useContentSearch.ts | Increased DEFAULT_MAX_RESULTS from 100 to 10000 |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User enters search query] --> B{Query length >= 2?}
B -->|No| C[Clear results]
B -->|Yes| D[Wait 400ms debounce]
D --> E{Local or Remote?}
E -->|Local| F[fsIpc.searchContent]
E -->|Remote| G[RemoteFileSystem.search]
F --> H[Collect up to 20,000 files]
H --> I[Search files in parallel batches]
I --> J[Return up to 10,000 matches]
G --> K[Execute grep command via SSH]
K --> L[Return up to 10,000 matches]
J --> M[ContentSearchResults component]
L --> M
M --> N[Display total matches and file count]
N --> O[Render all results without virtualization]
Last reviewed commit: 5ee3485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 1 comment
Additional Comments (1)
src/renderer/components/FileExplorer/ContentSearchResults.tsx
rendering thousands of results without virtualization could cause UI performance issues - consider implementing virtual scrolling if users search for common terms
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
fix: #983
This PR includes changes as:
Checks permed:
- Format
- build
image➜ happy-lines-yell-3pq git:(emdash/happy-lines-yell-3pq) ✗ git grep -il "relationshipManager" | wc -l 267