Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Increase search result limits and display total matches and fil...#996

Open
prath47 wants to merge 2 commits intogeneralaction:main from
prath47:fix-983
Open

feat: Increase search result limits and display total matches and fil... #996
prath47 wants to merge 2 commits intogeneralaction:main from
prath47:fix-983

Conversation

@prath47
Copy link
Contributor

@prath47 prath47 commented Feb 20, 2026

fix: #983

This PR includes changes as:

  1. increased files search limit to show all results
  2. Added ui to show search result numbers

Checks permed:

  1. Format
  2. build
    ➜ happy-lines-yell-3pq git:(emdash/happy-lines-yell-3pq) ✗ git grep -il "relationshipManager" | wc -l 267
image

greptile-apps[bot] reacted with thumbs up emoji
Copy link

vercel bot commented Feb 20, 2026

@prath47 is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

greptile-apps bot commented Feb 20, 2026

Greptile Summary

Increases search result limits from 100 to 10,000 across all search implementations (local, remote, and frontend) to provide comprehensive search results. Adds a user-friendly summary line showing total line matches and file count.

Changes:

  • Increased default maxResults to 10,000 in LocalFileSystem, RemoteFileSystem, fsIpc, and useContentSearch
  • Increased MAX_SEARCH_FILES from 5,000 to 20,000 in fsIpc to search more files
  • Added results summary UI displaying "found X lines in Y files"

Considerations:

  • The UI renders all results without virtualization, which may cause performance issues if common search terms return thousands of results
  • Search logic already includes safeguards (file size limits, binary file detection, parallel processing)
  • Remote search uses head -n 10000 to limit grep output

Confidence Score: 4/5

  • This PR is safe to merge with minor UI performance considerations
  • The changes are straightforward constant updates that improve search comprehensiveness. Existing safeguards (file size limits, binary detection, file count limits) prevent resource exhaustion. The main concern is potential UI lag when rendering thousands of results without virtualization, but this is a progressive enhancement opportunity rather than a blocker.
  • Consider adding virtual scrolling to ContentSearchResults.tsx if users report performance issues with large result sets

Important Files Changed

Filename Overview
src/main/services/fs/LocalFileSystem.ts Increased default maxResults from 100 to 10000
src/main/services/fs/RemoteFileSystem.ts Increased default maxResults from 100 to 10000 for remote search
src/main/services/fsIpc.ts Increased DEFAULT_MAX_SEARCH_RESULTS to 10000 and MAX_SEARCH_FILES to 20000
src/renderer/components/FileExplorer/ContentSearchResults.tsx Added search results summary showing total line matches and file count
src/renderer/hooks/useContentSearch.ts Increased DEFAULT_MAX_RESULTS from 100 to 10000

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
 A[User enters search query] --> B{Query length >= 2?}
 B -->|No| C[Clear results]
 B -->|Yes| D[Wait 400ms debounce]
 D --> E{Local or Remote?}
 E -->|Local| F[fsIpc.searchContent]
 E -->|Remote| G[RemoteFileSystem.search]
 F --> H[Collect up to 20,000 files]
 H --> I[Search files in parallel batches]
 I --> J[Return up to 10,000 matches]
 G --> K[Execute grep command via SSH]
 K --> L[Return up to 10,000 matches]
 J --> M[ContentSearchResults component]
 L --> M
 M --> N[Display total matches and file count]
 N --> O[Render all results without virtualization]
Loading

Last reviewed commit: 5ee3485

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link

greptile-apps bot commented Feb 20, 2026

Additional Comments (1)

src/renderer/components/FileExplorer/ContentSearchResults.tsx
rendering thousands of results without virtualization could cause UI performance issues - consider implementing virtual scrolling if users search for common terms

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug]: Search in Code Editor do not show all files

1 participant

Comments

AltStyle によって変換されたページ (->オリジナル) /