Skip to content

Navigation Menu

Sign in
Sign up

Typos found by codespell - #357

Open
DimitriPapadopoulos wants to merge 1 commit into
gaubert:master from
DimitriPapadopoulos:codespell
Open

Typos found by codespell #357
DimitriPapadopoulos wants to merge 1 commit into
gaubert:master from
DimitriPapadopoulos:codespell

Conversation

@DimitriPapadopoulos

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 26, 2021

Copy link
Copy Markdown

No description provided.

Comment thread src/sandbox/common_gmvault.py Outdated
"""
the_str = "\n================================================================\n"\
"Number of reconnections: %d.\nNumber of emails quarantined: %d.\n" \
"Number of reconnections: %d.\number of emails quarantined: %d.\n" \

@domainfun domainfun Oct 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to see typo fixes in this Pull Request, but this fix on line 423 may be incorrect? Perhaps the original line should be split into two lines for clarity, i.e. from:

"Number of reconnections: %d.\nNumber of emails quarantined: %d.\n" \
... to ...

"Number of reconnections: %d.\n" \
"Number of emails quarantined: %d.\n" \

@DimitriPapadopoulos DimitriPapadopoulos Oct 27, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought I had fixed this one. I'll have a look.

I had thought of splitting the line but wasn't certain you'd agree. If you do agree, i'll do that.

@DimitriPapadopoulos DimitriPapadopoulos Oct 27, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and split the lines - both for clarity and avoiding codespell false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@domainfun domainfun domainfun left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /