-
Notifications
You must be signed in to change notification settings - Fork 282
Draft
Conversation
brechmos
commented
Oct 18, 2019
Author
The part that isn't working currently is in imap_utils.py:
class GIMAPFetcher(object): #pylint:disable=R0902,R0904
'''
IMAP Class reading the information
'''
GMAIL_EXTENSION = b'X-GM-EXT-1' # GMAIL capability
GMAIL_ALL = '[Gmail]/All Mail' #GMAIL All Mail mailbox
GENERIC_GMAIL_ALL = '\\AllMail' # unlocalised GMAIL ALL
GENERIC_DRAFTS = '\\Drafts' # unlocalised DRAFTS
GENERIC_GMAIL_CHATS = gmvault_const.GMAIL_UNLOCAL_CHATS # unlocalised Chats names
FOLDER_NAMES = ['ALLMAIL', 'CHATS', 'DRAFTS']
GMAIL_ID = 'X-GM-MSGID' #GMAIL ID attribute
GMAIL_THREAD_ID = 'X-GM-THRID'
GMAIL_LABELS = 'X-GM-LABELS'
IMAP_INTERNALDATE = 'INTERNALDATE'
IMAP_FLAGS = 'FLAGS'
IMAP_ALL = {'type':'imap', 'req':'ALL'}
EMAIL_BODY = 'BODY[]'
GMAIL_SPECIAL_DIRS = ['\\Inbox', '\\Starred', '\\Sent', '\\Draft', '\\Important']
#GMAIL_SPECIAL_DIRS_LOWER = ['\\inbox', '\\starred', '\\sent', '\\draft', '\\important']
GMAIL_SPECIAL_DIRS_LOWER = ['\\inbox', '\\starred', '\\sent', '\\draft', '\\important', '\\trash']
I believe there are issues with the representation of the names of the folders. Not sure if it should be b'Mail All' etc etc. I think there is an encoding issue (which should be easy to fix).
txtsd
commented
Nov 30, 2020
Is this still being worked on?
gene1wood
commented
Dec 8, 2021
How does this relate to #284 which also seeks to make gmvault work in Python 3?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the beginnings of a switch to Python3. I am not an expert in moving code to Python3 :). One thing for someone to check is to make sure the conversion of
StringIOmakes sense.