-
Notifications
You must be signed in to change notification settings - Fork 182
Now MAC filter deny is supported. (Only accept was supported.) - #43
Now MAC filter deny is supported. (Only accept was supported.) #43zaibaq wants to merge 1 commit into
Conversation
02a153b to
ee858a8
Compare
zaibaq
commented
Oct 3, 2022
Any updates regarding this? @garywill
garywill
commented
Oct 4, 2022
Hi, @zaibaq .
Thank you for sending PR to us.
Your commit has 300+ lines changes, which is too hard for us to review.
Please make a freshnew commit (based on the latest commit in master branch) containing only the feature part. Ignore those blanks, exclude them from commit.
You can use some GUI tool to choose lines to put into a commit, like git gui, gitg, git-cola`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're changing the meaning of this variable (from "enable mac filter or not" to "macaddr_acl in hostapd.conf" ),
we should use a new variable name MACADDR_ACL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it blank (or use -1 or -99) is better. hostapd may add 3 as a valid value in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need >&2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable MAC_FILTER_TYPE would be unnecessary. Use that MACADDR_ACL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking ...
maybe we can make the script option like this:
--mac-filter-accept <accept_file>
--mac-filter-deny <deny_file>
then variable MAC_FILTER_FILE and option --mac-filter-file would be unnecessary .
--mac-filter-accept - will apply the default path /etc/hostapd/hostapd.accept.
--mac-filter-deny - similar to above
What do you think?
This is to support
--mac-filter-denyafter only--mac-filter-acceptwas supported.Use:
If you want to use deny acl, use the option
--mac-filter-deny. Similarly for accept acl, use--mac-filter-accept.Obviously, you cannot use both options at the same time.
If you want to set a specific path for the mac addresses file, whether you're using deny or accept, you need to set the option
--mac-filter-file <MAC_ADDRESSES_FILE>.