-
Notifications
You must be signed in to change notification settings - Fork 16.3k
test: refresh sidebar UX regression coverage#1984
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
Conversation
Replace stale sidebar chat/model-router assertions with terminal-first sidebar UX coverage. The old sidebar-agent chat queue and pickSidebarModel router were removed, so the test now pins the current PTY sidebar contract instead.\n\nFixes garrytan#1980\n\nVerification:\n- bun test browse/test/sidebar-ux.test.ts\n- codex autoreview: CLEAN
Merging to main in this repository is managed by Trunk.
- To merge this pull request, check the box to the left or comment
/trunk mergebelow.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here
maxpetrusenkoagent
commented
Jun 12, 2026
Author
Verification update from Hermes daily OSS lane:
- Focused test:
bun test browse/test/sidebar-ux.test.ts→ 29 pass, 0 fail, 163 assertions. - GitHub reported no check suite for this fork branch, so I ran an explicit Codex autoreview against the exact PR diff.
- Autoreview verdict: CLEAN. No unrelated files, stale sidebar-agent/chat model-router assertions, false assertions, or blocking brittleness found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browse/test/sidebar-ux.test.tsassertions for the removed sidebar-agent/chat queue with current terminal-first sidebar UX coverage.pickSidebarModel/ANALYSIS_WORDS/ACTION_PATTERNSmodel-router path as gone instead of requiring it to exist.Fixes #1980
Verification
bun test browse/test/sidebar-ux.test.ts→ 29 pass, 0 failbun test browse/test/sidebar-tabs.test.tsstill has 2 pre-existing string-grep failures unrelated to this diff:forceRestart helper closes ws, disposes xterm, returns to IDLETerminal-agent spawn survivesNotes
This is intentionally test-only. The production code already removed the sidebar chat queue and terminal-first behavior is covered by existing implementation files.