-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix(update-check): surface failed preamble checks#1982
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
fix(update-check): surface failed preamble checks #1982maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Merging to main in this repository is managed by Trunk.
- To merge this pull request, check the box to the left or comment
/trunk mergebelow.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here
@maxpetrusenkoagent
maxpetrusenkoagent
force-pushed
the
hermes/oss-pr-2026年06月12日-gstack-1974
branch
from
June 12, 2026 00:39
788027c to
d747803
Compare
maxpetrusenkoagent
commented
Jun 12, 2026
Author
Autoreview after latest force-push: Codex reviewed the exact GitHub PR diff for #1982 and returned CLEAN: no findings. Local verification on the pushed branch: bash -n bin/gstack-update-check, bun test browse/test/gstack-update-check.test.ts test/skill-validation.test.ts (369 pass, 0 fail), and git diff --check. Note: GitHub currently reports no checks for this fork draft PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHECK_FAILED exit=<n> cmd=<cmd>stdout sentinel for abnormalgstack-update-checkfailures.CHECK_FAILEDoutput.Fixes #1974.
Root cause
Skill preambles invoke
gstack-update-checkwith stderr suppressed and|| true, so a local script crash was indistinguishable from an up-to-date/no-output result. Withset -euo pipefail, state-file write/remove failures could terminate before the remote version was checked.Verification
bash -n bin/gstack-update-checkbun test browse/test/gstack-update-check.test.ts test/skill-validation.test.ts→ 369 pass, 0 fail on fork-base branch after cherry-picking the fixgit diff --checkbun run gen:skill-docs --dry-run --host claude→ freshbun run gen:skill-docs --dry-run --host codex→ freshbun run skill:checkwas attempted; it fails on pre-existing missing/stale optional host outputs (.factory,.kiro,.opencode,.slate,.cursor,.openclaw,.hermes,.gbrain). Claude and Codex generated outputs are fresh.Autoreview
CLEAN: no findings.Fork note
The branch is based on the current
maxpetrusenkoagent/gstack:mainfork tip because the fork cannot be server-synced past upstream workflow-file commits without GitHubworkflowOAuth scope. The PR diff againstgarrytan/gstack:maincontains only this focused fix.