-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Open
Conversation
...llback # Conflicts: # SKILL.md # autoplan/SKILL.md # benchmark-models/SKILL.md # benchmark/SKILL.md # browse/SKILL.md # canary/SKILL.md # codex/SKILL.md # context-restore/SKILL.md # context-save/SKILL.md # cso/SKILL.md # design-consultation/SKILL.md # design-html/SKILL.md # design-review/SKILL.md # design-shotgun/SKILL.md # devex-review/SKILL.md # document-generate/SKILL.md # document-release/SKILL.md # health/SKILL.md # investigate/SKILL.md # ios-clean/SKILL.md # ios-design-review/SKILL.md # ios-fix/SKILL.md # ios-qa/SKILL.md # ios-sync/SKILL.md # land-and-deploy/SKILL.md # landing-report/SKILL.md # learn/SKILL.md # make-pdf/SKILL.md # office-hours/SKILL.md # open-gstack-browser/SKILL.md # pair-agent/SKILL.md # plan-ceo-review/SKILL.md # plan-design-review/SKILL.md # plan-devex-review/SKILL.md # plan-eng-review/SKILL.md # plan-tune/SKILL.md # qa-only/SKILL.md # qa/SKILL.md # retro/SKILL.md # review/SKILL.md # scrape/SKILL.md # scripts/resolvers/preamble/generate-ask-user-format.ts # scripts/resolvers/preamble/generate-completion-status.ts # setup-browser-cookies/SKILL.md # setup-deploy/SKILL.md # setup-gbrain/SKILL.md # ship/SKILL.md # skillify/SKILL.md # spec/SKILL.md # sync-gbrain/SKILL.md
Merging to main in this repository is managed by Trunk.
- To merge this pull request, check the box to the left or comment
/trunk mergebelow.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env,.env.local, machine-local~/.config/recruitmagic/cli.env, and Codexenv_keyconfigbin/gstack-codex-probemain, with test coverage adjusted for interactive prose fallback vs headless blockingWhy
Codex can be installed and still fail gstack automation when the auth key only exists in a repo
.envfile.codex exec/codex -pneed auth in the process environment, and Codex can also use a configured Azure/OpenAIenv_keyfrom~/.codex/config.toml. The probe should mirror that reality.This also keeps the new AskUserQuestion fallback behavior compatible with Codex-style interactive chat hosts: no AUQ tool means render the decision as prose and wait, while headless sessions still block.
Tests
bun test test/codex-hardening.test.ts test/resolver-ask-user-format.test.ts test/preamble-compose.test.ts test/gen-skill-docs-idempotency.test.tsbun run gen:skill-docs --dry-run