Skip to content

fix(browse): honor GSTACK_CHROMIUM_PATH in headless launch() #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

shofel wants to merge 1 commit into garrytan:main

from shofel:fix-headless-chromium-path

+4 −0

Open

fix(browse): honor GSTACK_CHROMIUM_PATH in headless launch() #1968

Changes from all commits

Commits

Show all changes

Select commit

fix(browse): honor GSTACK_CHROMIUM_PATH in headless launch()

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

4 changes: 4 additions & 0 deletions browse/src/browser-manager.ts

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -377,6 +377,10 @@ export class BrowserManager {
		// on Linux root/CI/container, where the sandbox requires unprivileged user
		// namespaces that aren't available.
		chromiumSandbox: shouldEnableChromiumSandbox(),
	// Honor GSTACK_CHROMIUM_PATH here too. The bundled Playwright
	// chrome-headless-shell can't load shared libs on NixOS; pointing at a
	// system Chromium fixes headless rendering (e.g. make-pdf).
	...(process.env.GSTACK_CHROMIUM_PATH ? { executablePath: process.env.GSTACK_CHROMIUM_PATH } : {}),
		...(launchArgs.length > 0 ? { args: launchArgs } : {}),
		...(this.proxyConfig ? { proxy: this.proxyConfig } : {}),
		});
Expand Down