Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Render office-hours sketches over localhost#1945

Open
JonasFocus wants to merge 1 commit into
garrytan:main from
JonasFocus:fix/771-office-hours-http-sketch
Open

Render office-hours sketches over localhost #1945
JonasFocus wants to merge 1 commit into
garrytan:main from
JonasFocus:fix/771-office-hours-http-sketch

Conversation

@JonasFocus

@JonasFocus JonasFocus commented Jun 9, 2026

Copy link
Copy Markdown

Fixes #771

Summary:

  • Renders office-hours sketch HTML through a temporary 127.0.0.1 HTTP server instead of file://.
  • Keeps the browser local-file block intact.
  • Adds validation that the generated skill uses the localhost render path and no longer emits the blocked file URL.

Verification:

  • bun run gen:skill-docs --host all
  • bun test test/skill-validation.test.ts
  • bun test test/gen-skill-docs.test.ts
  • rg -n 'file://\\$SKETCH_FILE|python3 -m http.server|http://127\\.0\\.0\\.1:\\$SKETCH_PORT/\\$SKETCH_NAME' office-hours/SKILL.md scripts/resolvers/design.ts\n- git diff --check

trunk-io Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@JonasFocus JonasFocus marked this pull request as ready for review June 9, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

office-hours wireframe render silently fails because browse blocks file:// URLs

1 participant

AltStyle によって変換されたページ (->オリジナル) /