Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use REST for ship PR updates#1944

Open
JonasFocus wants to merge 1 commit into
garrytan:main from
JonasFocus:fix/1079-ship-rest-pr-update
Open

Use REST for ship PR updates #1944
JonasFocus wants to merge 1 commit into
garrytan:main from
JonasFocus:fix/1079-ship-rest-pr-update

Conversation

@JonasFocus

@JonasFocus JonasFocus commented Jun 9, 2026

Copy link
Copy Markdown

Fixes #1079

Summary:

  • Updates /ship existing-PR instructions to patch the PR body and title through gh api REST calls.
  • Keeps the same scanned PR body file, just sends it through the REST path.
  • Adds test coverage so the old gh pr edit --body-file path does not come back.

Verification:

  • bun run gen:skill-docs --host all
  • bun test test/ship-template-redaction.test.ts
  • bun test test/gen-skill-docs.test.ts
  • git diff --check

trunk-io Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@JonasFocus JonasFocus marked this pull request as ready for review June 9, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

/ship Step 19: gh pr edit fails on repos with deprecated GraphQL Projects classic fields

1 participant

AltStyle によって変換されたページ (->オリジナル) /