-
Notifications
You must be signed in to change notification settings - Fork 60
perf(messages): fold ASCII highlight segments once - #178
Open
YousefHadder wants to merge 1 commit into
Open
Conversation
willinghamlamont00-a11y
commented
Sep 4, 2026
Great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/text.Foldnow that PR perf(text): add ASCII fast path to Fold #174 centralizes the ASCII fast path.text.Foldfallback for non-ASCII and invalid UTF-8 so highlight indices and behavior remain unchanged.Behavior coverage
Behavior-level tests exercise the
HighlightSearchTermspackage seam, including decomposed combining-mark mapping (Cafe\u0301) to preserve the original rune-to-highlight relationship.Observed benchmark
Environment: Apple M3 Max, darwin/arm64.
Protocol:
text.FoldpathIn these measurements, the median was 33.5% lower and allocations decreased from 185 to 9 per operation. These are observed results on the environment above, not universal performance claims.
Context
This is the independent message-highlighting follow-up requested after PR #174 / issue #165. It is separate from the reaction-picker follow-up in PR #177.
Refs #165