-
Notifications
You must be signed in to change notification settings - Fork 130
configureWithOptions fix for android #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You're probably best off tackling this on my v3 fork of firestack if possible due to the current state of affairs here
hum why not. Since you dropped all options passing, it will require a little more work to include my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a google-services.json is provided, Firestack auto-configures itself (see this article), so there is no way to pass custom options afterwards.
Removing the google-services.json didn't solve the issue, since building a
FirebaseOptionswithout an applicationId throws an exception.This patch detects if the firebase default app is already configured, otherwise uses params to set it up, without trying to build an empty
FirebaseOptions.Il also refactored a little bit the way params keys are searched to be complient with the params in the ios version.
I think this patch might resolve most of the "FirebaseApp[DEFAULT] already configured" errors in android apps, like in #265
Maybe the README should be updated to state clearly that .plist/.json and options from js are mutually exclusives way to configure firestack.