-
Notifications
You must be signed in to change notification settings - Fork 130
FCM implementation #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
FCM implementation #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing filter value creation
Parity of response format between ios and android
...ticateWithCredentialForProvider Implement reauthenticateWithCredentialForProvider for Android
...rAuth Fix Android listenForAuth method to correctly check for user
...d flag to response from getCurrentUser
...tack * 'master' of github.com:fullstackreact/react-native-firestack: Fix Android listenForAuth method to correctly check for user
Parity of response format between ios and android.
...ing_comma Removing undefined's from filter arguments
Filter out undefined filters
forEach and map method on the DataSnapshot does not retain key
...alled. - Fix weird error that NSError is not KVC compliant when storage is not configured JS - Fixed code seems to exist on several more locations but has not been fixed, since there are no tests to ensure I don't break anything.
- Use storageUrl from default config if not set otherwise in JS - Similar code exists on several other places that are not fixed since no tests prevent breaking stuff.
Use storage url from .plist file if not setStorageUrl() hasn't been called
...tack * 'master' of github.com:fullstackreact/react-native-firestack: Fix donwloadUrl to use storageUrl from .plist. Use storage url from .plist file if not setStorageUrl() hasn't been called. Fixed error calling length of undefined forEach and map method on the DataSnapshot does not retain key removing trailing comma Filter out undefined filters Parity of response format between ios and android. Added authenticated flag to response from getCurrentUser
Update v3 with latest changes
Database.js was factored out into the database/ folder. This stuck
around for some reason and the require('modules/database') preferred
the old version
...dFile Implement storage.download() for Android
Most of the FCM implementation, local notifications could be cleaner...
I'll check this out this evening!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the FCM implementation, local notifications could be cleaner/need to be tested more. Would be helpful to know how the JS methods want to call and define these things so can know how to better convert to native iOS components i.e. UILocalNotification etc