Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added RemoteConfig API #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jeanmsilva89 wants to merge 1 commit into fullstackreact:master
base: master
Choose a base branch
Loading
from Jeanmsilva89:feature/config

Conversation

Copy link

@Jeanmsilva89 Jeanmsilva89 commented Nov 18, 2016

Re-added RemoteConfig feature.

rigobcastro reacted with thumbs up emoji
Copy link
Contributor

It seems configValueForKey only gets the stringValue of an item?

Before I discovered firestack, I had built out a firebase3 module myself for the remoteconfig and analytics stuff I had needed. If you're motivated to get this implemented, perhaps you'd be interested in stealing my remoteconfig code?

https://github.com/mikelambert/react-native-firebase3/blob/master/android/src/main/java/org/jall/reactnative/firebase/RNFIRRemoteConfig.java

https://github.com/mikelambert/react-native-firebase3/blob/master/ios/Firebase/RNFIRRemoteConfig.m

It definitely works in iOS, and I'm pretty sure it works in Android (my app is broken w.r.t. this right now, but I believe that's due to the recent inclusion of both rn-firestack and rn-firebase3 in my project, both trying to initialize fb under-the-hood)

Copy link

Hi,
have you an idea when this PR will be available ?

neacsugeorge reacted with thumbs up emoji

Copy link

+1 for both ios & android

neacsugeorge reacted with thumbs up emoji

Copy link

chatras commented Dec 31, 2016

When will this be available? Great work so far guys! Loving this library!

Copy link

Hi ! Do you know when you plan on releasing this ?

Copy link

nkashyap commented Feb 5, 2017

Here is PR for v3

Salakar#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /