-
Notifications
You must be signed in to change notification settings - Fork 60
Multi-year support #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+273
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...port? fspoettel#22) Other years bins and examples are moved to `./years/YYYY/`for storage.
...nal dependency which is now also needed by switch-year command.
Hi @FXCourel, thanks for taking the time to open this PR. I will give this a whirl after this year's aoc completes and see how it interacts with git etc.
I can't promise I'll merge it for the reasons you outlined, but I want to commend it as a very creative solution to the problem. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
🎄 Hello ! Thank you for this great tool !
I am personally interested for multi year support (sharing libraries between years, all in one repo) and I saw in #22 that I am not the only one to want this feature.
I found a way to deal with that, by storing other years files apart from the runner and implement a new command (
cargo switch-year <Year>
) to move these files. Multi-year benchmarks is supported (the one shown in the readme is the year that is currently set up by the user). However multi year star tracking is not supported.I tried to produce the cleanest code, but I know this system is not very satisfying as moving and managing folders is rather a workaround than a clean and safe solution. Still, I am happy with what I made and I will use it personally.
So this PR is a proof of concept, it's up to you to decide if you want to accept it (with reworks and improvement if needed, I may have forgotten compatibility issues with some features) or if you don't plan to make anything of this.
Would fix #22