-
Notifications
You must be signed in to change notification settings - Fork 326
target/ignore_error: add wrapper target to ignore delivery errors - #863
Open
ChrisJr404 wants to merge 1 commit into
Open
target/ignore_error: add wrapper target to ignore delivery errors #863ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #748.
Adds a
target.ignore_errorwrapper that runs an inner delivery target and turns any delivery error into a logged warning, so a non criticaldeliver_tocopy (push notifications and similar, like #735) does not fail the rest of the pipeline.The wrapped target is given inline, as in the issue example:
Any block attached to the directive is forwarded to the wrapped target as-is. Errors from every stage (StartDelivery, AddRcpt, Body, Commit) are logged and then discarded. If the wrapped target cannot be started at all the delivery becomes a no-op.
Comes with unit tests covering the passthrough and the ignored-error cases, plus a short reference page. Happy to switch to a
target {}block form instead of the inline one if you prefer that.