-
Notifications
You must be signed in to change notification settings - Fork 326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #857
There is a comment in the code:
maddy/internal/limits/limits.go
Lines 110 to 120 in e42741c
However, the maximum number of SMTP recipients is only limited per single connection. If more than 20,000 recipients are obtained through multiple connections within one minute, the bucket may also become full.
I considered whether should wait for the old limiter to be reaped. But with heavy load when the bucket is full, I think blocking the process is not a good idea.