Skip to content

Navigation Menu

Sign in
Sign up
This repository was archived by the owner on May 21, 2026. It is now read-only.

Fixed creation of double instances in memory graph activity, this fixes #627 - #632

Open
htg2704 wants to merge 1 commit into
fossasia:development from
htg2704:development
Open

Fixed creation of double instances in memory graph activity, this fixes #627 #632
htg2704 wants to merge 1 commit into
fossasia:development from
htg2704:development

Conversation

@htg2704

@htg2704 htg2704 commented Feb 17, 2020

Copy link
Copy Markdown

Fixes #[Add issue number here. Note: This will automatically closes the issue. If you do not solve the issue entirely, please change the message to e.g. "First steps for issues #IssueNumber]

Changes: [Add here what changes were made in this issue and if possible provide links.]

Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a *.gif containing a demonstration. Use <img src="paste-url-here" width=200/> to add images]

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]

@@ -1,4 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>


@CloudyPadmal CloudyPadmal Feb 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid making changes in unrelated files.

.setPositiveButton(R.string.focus_test_msg, (dialog, which) -> {
Intent intent = new Intent(getContext(), DataLoggerActivity.class);
intent.putExtra(ProgramModeActivity.PROGRAM_FLAG_KEY, MemoryGraphParent.MEMORY_GRAPH_FLAG);
intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK|Intent.FLAG_ACTIVITY_NEW_TASK|Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED);

@CloudyPadmal CloudyPadmal Feb 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformat the code. It will add spaces in between |'s

jddeep commented Jun 5, 2020

Copy link
Copy Markdown
Member

@htg2704 Any updates on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@CloudyPadmal CloudyPadmal CloudyPadmal requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /