This repository was archived by the owner on May 21, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 150
Open
Conversation
YashKumarVerma
commented
Dec 5, 2019
Member
It's a good practice to complete the work and then open a pull request, as it notifies the maintainers on every commit/action, which is not appreciated.
samyakbvs
commented
Dec 5, 2019
Contributor
Author
@YashKumarVerma I open the pull request first in order to check how my work reflects on the preview link
samyakbvs
commented
Dec 5, 2019
Contributor
Author
Travis is able to execute img_checker without any obstructions, but this gives rise to two more issues: #1070 and the tiles in the game have been displaced from their correct position from their current position.
@YashKumarVerma do you think I should fix the problem of displacement in this PR itself or should I start another one; I am a bit lost on why the problem of displacement is occurring, a little guidance would be helpful:).
Open
samyakbvs
commented
Dec 6, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changes done in this Pull Request
I have resized all the images to the required sizes.
Work in progress!