-
Notifications
You must be signed in to change notification settings - Fork 192
refactor: change in structure of stdlib in order to compiler it using fypp script #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To solve the issues, the following should be done:
- In
CMakeLists.txt: add"-I${PROJECT_SOURCE_DIR}/include"in the definition of thefyppFlags - In
test/CMakeLists.txt: remove the lines:
list(
APPEND fyppFlags
"-I${PROJECT_SOURCE_DIR}/src"
)
Did you also solve the issues with:
test_mean_f03.fyppnmash.c
?
Did you also solve the issues with:
* `test_mean_f03.fypp` * `nmash.c` ?
For nmhash.c, I have fixed the issues. Will push it.
For test_mean_f03.fypp, Still having the same issue. I have not been able to resolve it. Still working on it.
CMake build is failing since, it is not able to find
test_always_fail.f90&test_always_skip.f90as I have deleted those files.
Than you also have to remove the declaration of the tests from the CMake build files.
I remember we moved the
common.fyppfile fromsrctoincludedirectory. But seems like fpm-deployment script was not updated to handle that.
Should I change the include path of common.fypp in the .fypp files from which common.fypp not found error is coming in the fpm-deployment ?
Should I change the include path of
common.fyppin the.fyppfiles from whichcommon.fyppnot found error is coming in the fpm-deployment ?
No, I don't think so. Instead the variable fyflags in the fpm-deployement should be updated with the flag -I (similar to for the CMake files)
E.g., in my directory, I must adapt the fpm-deployment as follows:
...
fyflags="${fyglags} -I include"
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
?
As far as I remember, CPP is not used within stdlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is not used. But, we have not enabled fypp inside fpm as of now. So, it cannot identity it as a valid preprocessor. Considering fypp-gfortran.py as a temporary solution, I think when we have fypp integrated inside fpm then I think we should rename it as fypp instead of cpp.
To solve the issue with the Build-API-Docs, the directory include should be added/mentioned in the file API-doc-FORD-file.md (probably under the directive include:).
Hi @jvdp1, I still seem to face some issues with docs ci. Can you help me in resolving this?
This should be related to the version update of FORD, see #673 .
This should be related to the version update of FORD, see #673 .
@arteevraina Indeed it seems to be related to #673
@arteevraina Could you rebase your PR such that @zoziha chnages (#681) are also integrated into this PR, please?
Hopefully this will solve the issue with the CI.
This reverts commit 16d8b86.
6269e49 to
7c99e70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support extracting those values automatically in fpm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should add support to extract them for the version number ?
I will take up this task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR created for this fortran-lang/fpm#766
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that provided? IMO a link to fpm should be sufficient.
This Pull Request makes few structural changes in
stdlibto make get it compiled using the compiler wrapper script here.