Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

adding SPEC_TEMPLATE.md #504 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JHenneberg wants to merge 8 commits into fortran-lang:master
base: master
Choose a base branch
Loading
from JHenneberg:feature/He/addSpectemplate

Conversation

Copy link
Contributor

@JHenneberg JHenneberg commented Sep 7, 2021
edited
Loading

This is just the PR resulting from the discussion in #504.

@@ -31,6 +31,17 @@ You are welcome to propose changes to the style guide by
[opening an issue](https://github.com/fortran-lang/stdlib/issues/new/choose) or
[starting a discussion](https://github.com/fortran-lang/stdlib/discussions/new).

## Documentation
Copy link
Member

@aman-godara aman-godara Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new point needs to be added to the 6 bullet points above.

Copy link
Member

awvwgk commented Sep 7, 2021

Do you think it would be better to maintain such template in the wiki? The wiki might already be world-editable, if this is not the case, I can change the permissions there.

Copy link
Member

awvwgk commented Sep 7, 2021

An alternative would be to add the spec template to the pages directory such that it will be visible together with the specs at stdlib.fortran-lang.org.

Copy link
Contributor Author

Do you think it would be better to maintain such template in the wiki? The wiki might already be world-editable, if this is not the case, I can change the permissions there.

Personally I am not a fan of the wiki pages, because when you check out the repository you do not have access to them. Also to keep consistency with the other documents WORKFLOW.md etc I think it is better to have the SPEC_TEMPLATE.md.

This is just the PR resulting from the discussion in #504 , so we should continue the discussion there.

milancurcic and jvdp1 reacted with thumbs up emoji

Copy link
Member

FWIW I also don't like the WIki pages. Ideally when creating a new spec document, I'd like to just copy the spec template md file from the repo and fill it out.

jvdp1 reacted with thumbs up emoji

@awvwgk awvwgk added the documentation Improvements or additions to documentation label Sep 18, 2021
@JHenneberg JHenneberg force-pushed the feature/He/addSpectemplate branch from ac99c48 to 2db6d5f Compare October 8, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aman-godara aman-godara aman-godara left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /