-
Notifications
You must be signed in to change notification settings - Fork 194
draft for joss paper on sparse matrices #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with this format. Overall LGTM. I just have a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for a new feature: call dense2csr(A, CSR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could embed the call in just one. Actually I think it might be interesting to have a single interface to automatically detect the input and output matrices such as to internally apply the conversions having a unified API. Haven't thought it through yet though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be something like:
subroutine dense2sparse_${s1}$(dense,sparse) ${t1},ドル intent(in) :: dense(:,:) class(base_${s1}$_type), intent(out) :: sparse select type (sparse) type is (COO_${s1}$_type) type is (...) end subroutine
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Opening stand-alone branch to manage joss paper