-
Notifications
You must be signed in to change notification settings - Fork 154
test: add #require flint? for the test suite. - #848
Merged
Merged
Conversation
cbmarini
marked this pull request as ready for review
June 17, 2026 18:10
coveralls
commented
Jun 17, 2026
coverage: 62.903% (+0.06%) from 62.841% — cbmarini:require-flint into form-dev:master
tueda
tueda
approved these changes
Jun 17, 2026
@tueda
tueda
left a comment
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would like to add a FLINT-specific property flint?, I think the implementation would be fine.
(The original idea was feature?("flint"), which can be implemented by converting the -vv output into a set of available features and checking whether "flint" is included in that set, but this can be added later.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the instruction
#require flint?such that tests that depend on code that uses the Flint library are skipped if Form is build without it. At the moment it is tested in #845, so if we merge it from this PR I can rebase #845 and remove the commit there.