-
Notifications
You must be signed in to change notification settings - Fork 154
Checking FLINT version - #703
Merged
Merged
Conversation
jodavies
commented
Aug 25, 2025
Collaborator
For sensible runtimes we'd need to cache the flint build, as you do for the macos tests, for the linux jobs.
tueda
force-pushed
the
pr/flint-version-check
branch
from
August 26, 2025 08:37
92f1868 to
39e2dd5
Compare
tueda
commented
Aug 26, 2025
Collaborator
Author
Rebased onto #622.
tueda
force-pushed
the
pr/flint-version-check
branch
from
August 26, 2025 10:42
39e2dd5 to
db91484
Compare
jodavies
commented
Sep 3, 2025
Collaborator
If we require at least v3.2.0, we could also remove the "workaround" here:
form/sources/flintinterface.cc
Lines 1724 to 1751 in e3eeea3
#[ flint::startup_init :
*/
// The purpose of this function is it work around threading issues in flint, reported in
// https://github.com/flintlib/flint/issues/1652 and fixed in
// https://github.com/flintlib/flint/pull/1658 . This implies versions prior to 3.1.0,
// but at least 3.0.0 (when gr was introduced).
void flint::startup_init(void) {
#if __FLINT_RELEASE >= 30000
// Here we initialize some gr contexts so that their method tables are populated. Crashes have
// otherwise been observed due to these two contexts in particular.
fmpz_t dummy_fmpz;
fmpz_init(dummy_fmpz);
fmpz_set_si(dummy_fmpz, 19);
gr_ctx_t dummy_gr_ctx_fmpz_mod;
gr_ctx_init_fmpz_mod(dummy_gr_ctx_fmpz_mod, dummy_fmpz);
gr_ctx_clear(dummy_gr_ctx_fmpz_mod);
gr_ctx_t dummy_gr_ctx_nmod;
gr_ctx_init_nmod(dummy_gr_ctx_nmod, 19);
gr_ctx_clear(dummy_gr_ctx_nmod);
fmpz_clear(dummy_fmpz);
#endif
}
/*
#] flint::startup_init :
tueda
force-pushed
the
pr/flint-version-check
branch
from
September 4, 2025 01:50
db91484 to
ed1328f
Compare
tueda
commented
Sep 4, 2025
Collaborator
Author
If we require at least v3.2.0, we could also remove the "workaround" here:
Right. I have pushed a commit that completely removes the workaround.
Do you think we should leave an empty hook, like flint_startup_init in AllocSetups, just in case we need it again in the future?
jodavies
commented
Sep 4, 2025
Collaborator
I don't think so, it would be straightforward to add back in if it becomes necessary in the future.
jodavies
commented
Sep 5, 2025
Collaborator
At this point we should also recommend flint >=3.2.0 (and zstd) in the README.md and INSTALL files.
Disallow FLINT versions earlier than 3.2.0 by performing a preprocessor-based check during configure.
Add a runtime check that disallows FLINT versions earlier than 3.2.0. Note that the version check is also performed during the configure step. A runtime failure typically indicates that an incorrect shared library was linked.
We now require FLINT >= 3.2.0. The workaround is no longer necessary.
tueda
force-pushed
the
pr/flint-version-check
branch
from
September 30, 2025 09:41
ce61f51 to
7813cf6
Compare
tueda
commented
Sep 30, 2025
Collaborator
Author
TODO: README.md and INSTALL files must be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds checks both at configuration and at runtime to require FLINT 3.2.0 or later. Resolves #679.
(削除) Note: Many test jobs are currently failing due to old FLINT versions. (削除ここまで)Update: This PR depends on: