-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Conversation
...on of new error handling information and add line number to it.
@mthamil
mthamil
changed the title
(削除) Provide line number in error hander (削除ここまで)
(追記) Provide line number in error handler (追記ここまで)
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would find it useful to have the line number available for error handling.
This pull request includes backward compatible refactoring to introduce a
FlatFileErrorContextobject that contains all relevant information about a parsing error. This should simplify the introduction of any more error details in the future. In addition to the existing properties,LineandException, I added the line number to this context.