-
Notifications
You must be signed in to change notification settings - Fork 380
Check errors from Close method in SavePNG and SaveJPG#176
Open
peterstace wants to merge 1 commit intofogleman:master from
Open
Check errors from Close method in SavePNG and SaveJPG #176peterstace wants to merge 1 commit intofogleman:master from
peterstace wants to merge 1 commit intofogleman:master from
Conversation
When closing the file, errors can still occur that might not be surfaced during the writes from `png.Encode` and `jpeg.Encode`. By returning the error from `file.Close()`, these cases can be caught.
sbinet
commented
May 11, 2023
FYI, something along these lines has been done in "my" fork of gg:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When closing the file, errors can still occur that might not be surfaced during the writes from
png.Encodeandjpeg.Encode. By returning the error fromfile.Close(), these cases can be caught.